Skip to content

RFC: Deprecate date_sunrise and date_sunset constants #12978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2024
Merged

RFC: Deprecate date_sunrise and date_sunset constants #12978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7cdd95b
Deprecate constants SUNFUNCS_RET_TIMESTAMP, SUNFUNCS_RET_STRING and S…
jorgsowa Dec 19, 2023
00a0f41
Added @deprecated PHPDoc comments to constants
jorgsowa Dec 20, 2023
bee7d42
Updated date stub
jorgsowa Mar 19, 2024
eefb1f8
Merge branch 'master' into deprecate_date_sunrise_constants
TimWolla Aug 4, 2024
42aab8b
NEWS/UPGRADING
TimWolla Aug 4, 2024
f9bfbc1
Fix typo in UPGRADING
TimWolla Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ PHP NEWS
. Updated build system scripts config.guess to 2024-07-27 and config.sub to
2024-05-27. (Peter Kokot)

- Date:
. Constants SUNFUNCS_RET_TIMESTAMP, SUNFUNCS_RET_STRING, and SUNFUNCS_RET_DOUBLE
are now deprecated. (Jorg Sowa)

- DOM:
. Fixed bug GH-15192 (Segmentation fault in dom extension
(html5_serializer)). (nielsdos)
Expand Down
4 changes: 4 additions & 0 deletions UPGRADING
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,10 @@ PHP 8.4 UPGRADE NOTES
- Date:
. Calling DatePeriod::__construct(string $isostr, int $options = 0) is
deprecated. Use DatePeriod::createFromISO8601String() instead.
. Constants SUNFUNCS_RET_TIMESTAMP, SUNFUNCS_RET_STRING, and
SUNFUNCS_RET_DOUBLE are now deprecated, following the deprecation of
the associated date_sunset() and date_sunrise() functions in PHP 8.1.
RFC: https://wiki.php.net/rfc/deprecations_php_8_4

- Intl:
. Calling intlcal_set() as well as calling IntlCalendar::set() with
Expand Down
3 changes: 3 additions & 0 deletions ext/date/php_date.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,18 +83,21 @@
/**
* @var int
* @cvalue SUNFUNCS_RET_TIMESTAMP
* @deprecated
*/
const SUNFUNCS_RET_TIMESTAMP = UNKNOWN;

/**
* @var int
* @cvalue SUNFUNCS_RET_STRING
* @deprecated
*/
const SUNFUNCS_RET_STRING = UNKNOWN;

/**
* @var int
* @cvalue SUNFUNCS_RET_DOUBLE
* @deprecated
*/
const SUNFUNCS_RET_DOUBLE = UNKNOWN;

Expand Down
8 changes: 4 additions & 4 deletions ext/date/php_date_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions ext/date/tests/date_sunrise_and_sunset_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,13 @@ var_dump(gettype(date_sunset(time())));
--EXPECTF--
Basic test for date_sunrise() and date_sunset()

Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d

Deprecated: Function date_sunrise() is deprecated since 8.1, use date_sun_info() instead in %s on line %d
%s %s %d %d, sunrise time : %d:%d

Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d

Deprecated: Function date_sunset() is deprecated since 8.1, use date_sun_info() instead in %s on line %d
%s %s %d %d, sunset time : %d:%d

Expand Down
5 changes: 4 additions & 1 deletion ext/reflection/tests/internal_parameter_default_value/check_all.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,8 @@ foreach (get_declared_classes() as $class) {

?>
===DONE===
--EXPECT--
--EXPECTF--
Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d

Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d
===DONE===
Loading