Skip to content

ext/openssl: fix libressl build. #12919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen
Copy link
Member Author

subsidiary question, is this value still valid today ? Seems openssl had updated it circa 2016 to 512.

@devnexen
Copy link
Member Author

devnexen commented Jan 2, 2024

ping @bukka when you can, it s a little change :)

@devnexen devnexen requested a review from nielsdos January 14, 2024 13:15
@nielsdos
Copy link
Member

I guess I'm not understanding something here, I built the 8.2 branch with libreSSL and the build just worked fine.
This may be because in my configuration OPENSSL_NO_ENGINE was defined in my libreSSL build, but I'm not seeing a way to enable that (I'm not a libreSSL specialist).

@devnexen
Copy link
Member Author

So the only case I know is openbsd, however I realise last year they added OPENSSL_NO_ENGINE to their system libcrypto settings.

@nielsdos
Copy link
Member

So the only case I know is openbsd, however I realise last year they added OPENSSL_NO_ENGINE to their system libcrypto settings.

I'm building on Linux. I just tried v 3.8.0 which doesn't have that commit, but the build still works...

@devnexen
Copy link
Member Author

So to summarize on OpenBSD :
1/ 7.3 and prior, linkage issue: implicit declaration of function ENGINE_cleanup.
2/ 7.4 and master no issue.

@nielsdos
Copy link
Member

I trust you on this if it resolves the build for you. I don't see how this PR could cause issues so even if it were hypothetically wrong / not necessary it should be fine.

@devnexen devnexen closed this in 5e2a586 Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants