Skip to content

Intercept strlcpy and strlcat for msan on Clang 17 #12674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

iluuu1994
Copy link
Member

No description provided.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right, and works for me.
But I am surprised msan doesn't do this for us.

@iluuu1994
Copy link
Member Author

@nielsdos Indeed. I'm also not sure what changed in MSAN that makes this issue suddenly arise.

@nielsdos
Copy link
Member

🤷 oh well. FTR I found that isolated from php that msan also complains about these functions. So it is not php-specific.

@iluuu1994 iluuu1994 merged commit 16f39ec into php:master Nov 15, 2023
@iluuu1994 iluuu1994 mentioned this pull request Sep 8, 2024
iluuu1994 added a commit that referenced this pull request Sep 9, 2024
* PHP-8.2:
  Intercept strlcpy and strlcat for msan on Clang 17 (#12674)
iluuu1994 added a commit that referenced this pull request Sep 9, 2024
* PHP-8.3:
  Intercept strlcpy and strlcat for msan on Clang 17 (#12674)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants