Skip to content

Run nightly on single branch with workflow_dispatch and explicit branch #12649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

Run nightly on single branch with workflow_dispatch and explicit branch #12649

merged 1 commit into from
Nov 14, 2023

Conversation

iluuu1994
Copy link
Member

No description provided.

@iluuu1994 iluuu1994 requested a review from TimWolla as a code owner November 10, 2023 19:54
@iluuu1994
Copy link
Member Author

We have some matrix.branch.ref == 'master' checks in nightly.yml. Just from the branch name we cannot know whether the branch is based on master. I'll try to look at main/php_version.h.

@iluuu1994 iluuu1994 force-pushed the nightly-workflow_dispatch-branch branch from 9282863 to 70129e2 Compare November 11, 2023 20:34
@iluuu1994
Copy link
Member Author

I opted not to spell out (needs.GENERATE_MATRIX.outputs.version.major == 8 && needs.GENERATE_MATRIX.outputs.version.minor >= 3) || needs.GENERATE_MATRIX.outputs.version.major > 8 everywhere. 🙂 @TimWolla Please have another look, if you don't mind.

@iluuu1994 iluuu1994 merged commit 90fda03 into php:master Nov 14, 2023
@iluuu1994
Copy link
Member Author

Thanks @TimWolla!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iluuu1994 @TimWolla