following-up on GH-12551: removing inet_ntoa usage #12554
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
no_inet_ntoa_2
branch
from
ce58034 to
20d015b
Compare
Girgias
reviewed
Oct 29, 2023
Comment on lines
657
to
661
| if (inet_ntop(AF_INET, &myaddr, str, sizeof(str))) { | ||
| RETURN_STRING(str); | ||
| } else { | ||
| RETURN_FALSE; | ||
| } |
There was a problem hiding this comment.
Can this actually fail? because otherwise the call to this in dns.c looks fishy?
There was a problem hiding this comment.
I would need to recheck some of them indeed.
devnexen
force-pushed
the
no_inet_ntoa_2
branch
from
20d015b to
addf152
Compare
devnexen
force-pushed
the
no_inet_ntoa_2
branch
from
cacaca6 to
07d53ff
Compare
Girgias
reviewed
Nov 4, 2023
There was a problem hiding this comment.
Looking at https://man7.org/linux/man-pages/man3/inet_ntop.3.html it seems like it shouldn't be possible to hit the error conditions? So maybe just adding an assertion that we always have a value is enough, instead of handling those cases?
|
I admit most seem over zealous but would like to change to assertions in a later PR. |
|
ACK |
Girgias
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.