Fix #47531: No way of removing redundant xmlns: declarations #12542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it's possible via removeAttribute("xmlns:prefix").
It was not possible to reuse a libxml2 function to reconcile because it
does not align with DOM behaviour.
Girgias
reviewed
Oct 28, 2023
| return; | ||
| } | ||
| worklist_capacity = worklist_capacity * 3 / 2; | ||
| worklist = erealloc(worklist, sizeof(dom_deep_ns_redef_item) * worklist_capacity); |
There was a problem hiding this comment.
Maybe use safe_erealloc() instead?
There was a problem hiding this comment.
This looks sensible to me, maybe this should land in 8.3?
Probably. Could be landed in even lower versions as this is a proper bugfix, but I don't dare to do that because of reasons you know...
Maybe use safe_erealloc() instead?
I have to check for overflow of doing *3/2 already, so I folded the overflow check for sizeof(dom_deep_ns_redef_item) * worklist_capacity into that one already. I therefore don't think it's necessary to use safe_erealloc.
There was a problem hiding this comment.
ACK for the realloc.
8.3 should be safe as it hasn't been "properly" released yet IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's possible via removeAttribute("xmlns:prefix"). It was not possible to reuse a libxml2 function to reconcile because it does not align with DOM behaviour.