Remove unused variable 'error' #12438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will also get rid of the potential allocation happening in zend_is_callable_ex().
Girgias
approved these changes
Oct 15, 2023
| @@ -654,14 +653,12 @@ PHP_FUNCTION(pcntl_signal) | |||
| RETURN_TRUE; | |||
| } | |||
|
|
|||
| if (!zend_is_callable_ex(handle, NULL, 0, NULL, NULL, &error)) { | |||
| if (!zend_is_callable_ex(handle, NULL, 0, NULL, NULL, NULL)) { | |||
| PCNTL_G(last_error) = EINVAL; | |||
There was a problem hiding this comment.
Does it actually make sense to set the last error here?
There was a problem hiding this comment.
I think so, EINVAL is for invalid arguments, and the argument is definitely not valid if this check fails.
There was a problem hiding this comment.
Well sure, but also this used to return false and a warning and not a TypeError, but eh I don't think it's super important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will also get rid of the potential allocation happening in zend_is_callable_ex().