-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Close PHP tags in tests #12422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close PHP tags in tests #12422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for dom, libxml, xsl
0d60d9e
to
ff1ba85
Compare
@@ -7,5 +7,6 @@ Note: the closing ?> has been deliberately elided. | |||
|
|||
echo <<<'END' | |||
|
|||
?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is incorrect as per the description.
@@ -7,5 +7,6 @@ Note: the closing ?> has been deliberately elided. | |||
|
|||
echo <<<END | |||
|
|||
?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -4,5 +4,6 @@ Unterminated comment | |||
<?php | |||
/* Foo | |||
Bar | |||
?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks intentional.
Some of these may be intended, I'll check and revert them manually.
Script I used to fix these:
Edit: Thank you Labeler Bot for that.