Skip to content

Report error if JIT cannot be enabled #12404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

danog
Copy link
Contributor

@danog danog commented Oct 10, 2023

No description provided.

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @dstogov Do you think this is ok?

Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>
@danog
Copy link
Contributor Author

danog commented Oct 10, 2023

To be honest, I know I should probably add more specific logging in case of failures directly inside the JIT init logic, but since it was full of todos for error reporting I wasn't sure whether it was possible to add a zend_accel_error in there...

Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iluuu1994 iluuu1994 closed this in 7177461 Oct 11, 2023
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request May 11, 2024
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request May 11, 2024
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request May 11, 2024
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants