Remove redundant code in ext/mysqlnd build #12384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was once used by the ext/mysqli when building without ext/mysqlnd and the ext/mysqlnd/php_mysqlnd_config.h file was created in the build directory.
petk
force-pushed
the
patch-autoconf-mysqlnd
branch
from
71247cb to
3b5cc7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's one more redundant code cleanup. This was once used by the ext/mysqli when building without ext/mysqlnd and the ext/mysqlnd/php_mysqlnd_config.h file was created in the build directory. This has been tested with in-source build, out-of-source build, shared extensions, compiled in the php binary etc. So it's safe to remove it today.