Skip to content

Use zend_error_noreturn for E_ERROR consistently #12204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use zend_error_noreturn for E_ERROR consistently #12204

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

To be clear, these already don't return. zend_error_noreturn just hints at this fact through the ZEND_NORETURN attribute.

@iluuu1994
Use zend_error_noreturn for E_ERROR consistently
d9be218 
To be clear, these already don't return. zend_error_noreturn just hints at this
fact through the ZEND_NORETURN attribute.
@iluuu1994 iluuu1994 closed this in 692cea5 Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov Awaiting requested review from dstogov dstogov will be requested when the pull request is marked ready for review dstogov is a code owner

@bukka bukka Awaiting requested review from bukka bukka will be requested when the pull request is marked ready for review bukka is a code owner

@devnexen devnexen Awaiting requested review from devnexen devnexen will be requested when the pull request is marked ready for review devnexen is a code owner

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi will be requested when the pull request is marked ready for review SakiTakamachi is a code owner

@derickr derickr Awaiting requested review from derickr derickr will be requested when the pull request is marked ready for review derickr is a code owner

Assignees
No one assigned
Labels
Category: Engine Extension: date Extension: ffi Extension: gd Extension: intl Extension: opcache Extension: pdo (core) Extension: pgsql Extension: sodium Extension: zend_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iluuu1994