Fix segfault when DOMParentNode::prepend() is called when the child disappears #11906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
omg, there's still an issue here even after this fix 😞 |
|
Pushed the change, I'll check and test out append() tomorrow |
Girgias
approved these changes
Aug 8, 2023
Comment on lines
+18
to
+25
| $test = $doc->createElement('foo'); | ||
| $test->append($child); | ||
| echo $doc->saveXML(); | ||
| echo $doc->saveXML($test), "\n"; | ||
| $test->prepend($child); | ||
| echo $doc->saveXML(); | ||
| echo $doc->saveXML($test), "\n"; | ||
| $test->append($child); |
There was a problem hiding this comment.
I can't make out where the output of one echo ends and where another echo starts.
Maybe add some ``echo "----------\n";` to make it more obvious?
There was a problem hiding this comment.
I've done so in the merge. If you're interested: d19e4da#diff-8386e35f446a7f90b1425135e71fddb65f86c1c115255c0a454878881e7beeb2
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.