Skip to content

Add php_version and php_version_id PHPAPI funcs #11875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

morrisonlevi
Copy link
Contributor

@morrisonlevi morrisonlevi commented Aug 4, 2023

Mostly, extensions will use PHP_VERSION and PHP_VERSION_ID respectfully but sometimes they want to grab the version at run-time rather than at compile-time. For example, extensions which distribute pre-built binaries may want this.

Mostly, extensions will use PHP_VERSION and PHP_VERSION_ID respectfully
but sometimes they want to grab the version they run against at run-
time rather than at compile-time.
@morrisonlevi morrisonlevi requested a review from bukka as a code owner August 4, 2023 15:02
@morrisonlevi morrisonlevi changed the title Add php_version and php_version_id PHPAPI funcs Add php_version and php_version_id PHPAPI funcs Aug 4, 2023
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

@morrisonlevi morrisonlevi merged commit 0311e60 into php:master Aug 4, 2023
@morrisonlevi morrisonlevi deleted the levim/phpapi-version-funcs branch August 4, 2023 21:39
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Aug 16, 2023
Mostly, extensions will use `PHP_VERSION` and `PHP_VERSION_ID`
respectfully but sometimes they want to grab the version at run-time
rather than at compile-time. For example, extensions which distribute
pre-built binaries may want this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants