Don't test without opcache on push #11867
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's very rare for something to fail with opcache but not without opcache. One valuable information lost here is whether something is cause by opcache/JIT. But this can be verified locally when assessing the problem. Alternatively we may look into triggering specific jobs on-demand.
|
Not unnecessarily heating the planet is a good thing and this should also reduce the turn-around time for test results to arrive which is also a good thing. I also agree with Girgias' suggestion to keep it for one of the jobs, because “both-OS-and-non-opcache-specific” failures should likely be super rare. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very rare for something to fail without opcache but not with opcache. We will still run without opcache in nightly. One valuable information lost here is whether something is caused by opcache/JIT. But this can be verified locally when assessing the problem. Alternatively we may look into triggering specific jobs on-demand.
Let me know what you think. I don't want to remove something useful, but it seems like it wouldn't make much of a difference.