Refactor pcntl_sigprocmask()/pcntl_sigwaitinfo()/pcntl_sigtimedwait() #11860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Aug 2, 2023
|
|
Girgias
force-pushed
the
pcntl-refactoring
branch
2 times, most recently
from
5122ac0 to
38f6734
Compare
Girgias
commented
Aug 3, 2023
| bool(false) | ||
| sigtimedwait with invalid arguments | ||
| Error triggered | ||
| int(-1) |
There was a problem hiding this comment.
Really this issue should have been caught way before...
Girgias
commented
Aug 3, 2023
Girgias
changed the title
devnexen
reviewed
Aug 4, 2023
Girgias
force-pushed
the
pcntl-refactoring
branch
from
8670d1a to
5cda41e
Compare
|
I forgot about this PR... @bukka this is kinda bugfixing some of the return values but is also adding Value and Type errors, is this too late to include in 8.3 considering it has hit RC phase? |
|
Yeah it is a bug fix but a BC breaking bug fix so I think it needs to go to master only. As I mentioned elsewhere I don't think we should introduce any changes to UPGRADING in RC stage. It's just too late and we want users to start migrating their applications and test PHP 8.3 on them. So we should not introduce any further BC break that might impact application migration. |
Girgias
force-pushed
the
pcntl-refactoring
branch
from
5cda41e to
8887df9
Compare
Girgias
force-pushed
the
pcntl-refactoring
branch
from
e92b821 to
f310683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add some validations which throw ValueError/TypeErrors.
Besides, found a bug in which in certain cases it wouldn't return false on failure, I think this should be fixed but probably just for master/PHP 8.3?
Still need to write the UPGRADING bit