Skip to content

github: add build scripts to "Category: Build System" label #11474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

the-eater
Copy link
Contributor

@the-eater the-eater commented Jun 18, 2023

Currently in #11427 it keeps removing the build system labels, even though all m4 files, and w32 files for that matter are build system related

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also list buildconf.* and configure.ac?

@the-eater
Copy link
Contributor Author

Yes, good call, I went through the source to see if there was any other missing, and so far only found win32/build outside that, unless I am missing some obscure part of the php build system, this should cover it :)

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, thank you!

@the-eater the-eater force-pushed the fix-configure-categorisation branch from cc727a4 to 869ba81 Compare June 21, 2023 18:33
@the-eater the-eater force-pushed the fix-configure-categorisation branch from 869ba81 to d273eb4 Compare June 21, 2023 19:20
@iluuu1994 iluuu1994 merged commit 165a4e5 into php:master Jun 22, 2023
@iluuu1994
Copy link
Member

Perfect, thank you @the-eater!

@the-eater the-eater deleted the fix-configure-categorisation branch June 22, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants