fix: use zval_get_long() to read value of FTP context option "overwrite"

[JonasQuinten]

The FTP context option "overwrite" is read directly via Z_LVAL_P without performing a type check or conversion. Because of this, the option only works reliably if it's set to an integer or if it's absent (defaulting to false), while setting it explicitly to false or null will likely allow overwriting and setting it to true has a small chance of disabling it.

I tried to implement the behavior as described in the commit that added the option (cb89565):

Allow overwriting of files via ftp:// wrapper.
Requires context option:  $context['ftp']['overwrite'] != 0

[nielsdos]

Thanks for your interest in fixing this. This definitely looks like a bug. You might want to use zend_is_true(zval*) instead though because it's explicitly meant for getting a true/false boolean from a zval.

[JonasQuinten]

I used zval_get_long because of the commit message, but I agree that zend_is_true is preferable. It also better matches the documentation that way.

[nielsdos]

I think this looks good, and CI agrees, thanks for updating.
Are you able to also add a test?
Also, is there a reason you put this as a draft PR?

[JonasQuinten]

Yeah, I'll try to add a test.
And there isn't really a reason for this to be a draft.

[nielsdos]

@JonasQuinten I'm okay with taking this patch as-is without dedicated test, since it's a very small patch and there is identical code doing it correctly. Do you still like to provide a testcase?

[iluuu1994]

@nielsdos While a test case is preferable, this should be fine merging without one.

[nielsdos]

Thanks!