Skip to content

Implement delyed early binding for classes without parents #11230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented May 11, 2023

Fixes GH-8846

Reduced scope of GH-11227, it avoids storing classes without parents in inheritance cache during delayed early binding.

Once again, this depends on GH-11226, which should be merged first.
Done.

Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@iluuu1994 iluuu1994 force-pushed the gh-8846 branch 2 times, most recently from 66764f5 to 8424fa5 Compare May 12, 2023 17:23
@staabm
Copy link
Contributor

staabm commented May 12, 2023

Typo in commit message: "delayed"

Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@iluuu1994
Copy link
Member Author

Merged as 0600f51. @staabm The typo was fixed when merging.

@iluuu1994 iluuu1994 closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opcache corruption
4 participants