Implement implicit move optimisation #11166
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| <?php | ||
|
|
||
| function array_merge_loop($n) { | ||
| $a = range(1, 3); | ||
| for ($i = 0; $i < $n; ++$i) { | ||
| $a = array_merge($a, [1, 2, 3]); | ||
| } | ||
| } | ||
|
|
||
| function array_merge_loop_with_temporary($n) { | ||
| $a = []; | ||
| for ($i = 0; $i < $n; ++$i) { | ||
| $a = array_merge($a, [1, 2]) + [100]; | ||
| } | ||
| } | ||
|
|
||
| function array_merge_loop_nested($n) { | ||
| $a = []; | ||
| for ($i = 0; $i < $n; ++$i) { | ||
| $a = array_merge($a, [1, 2]) + [$a]; | ||
| } | ||
| } | ||
|
|
||
| function array_unique_loop($n) { | ||
| $a = range(1, 2000); | ||
| $a += $a; | ||
| for ($i = 0; $i < $n; ++$i) { | ||
| $a = array_unique($a); | ||
| } | ||
| } | ||
|
|
||
| function user_func_helper($array) { | ||
| for ($i = 0; $i < 100; $i++) { | ||
| $array[$i] = $i; | ||
| } | ||
| return $array; | ||
| } | ||
|
|
||
| function user_func($n) { | ||
| $a = []; | ||
| for ($i = 0; $i < $n; ++$i) { | ||
| $a = user_func_helper($a); | ||
| } | ||
| } | ||
|
|
||
| /*****/ | ||
|
|
||
| require 'bench_common.php'; | ||
|
|
||
| const N = 30000; | ||
|
|
||
| $t0 = $t = start_test(); | ||
| empty_loop(N); | ||
| $t = end_test($t, 'empty_loop'); | ||
| $overhead = $last_time; | ||
| array_merge_loop(N); | ||
| $t = end_test($t, 'array_merge', $overhead); | ||
| array_merge_loop_with_temporary(N); | ||
| $t = end_test($t, 'array_merge temp', $overhead); | ||
| array_merge_loop_nested(N); | ||
| $t = end_test($t, 'array_merge nest', $overhead); | ||
| array_unique_loop(N); | ||
| $t = end_test($t, 'array_unique', $overhead); | ||
| user_func(N); | ||
| $t = end_test($t, 'user_func', $overhead); | ||
| total($t0, "Total"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -345,41 +345,7 @@ function strcat($n) { | |
|
|
||
| /*****/ | ||
|
|
||
| require 'bench_common.php'; | ||
|
|
||
| $t0 = $t = start_test(); | ||
| simple(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <?php | ||
|
|
||
| function empty_loop($n) { | ||
| for ($i = 0; $i < $n; ++$i) { | ||
| } | ||
| } | ||
|
|
||
| function gethrtime() | ||
| { | ||
| $hrtime = hrtime(); | ||
| return (($hrtime[0]*1000000000 + $hrtime[1]) / 1000000000); | ||
| } | ||
|
|
||
| function start_test() | ||
| { | ||
| ob_start(); | ||
| return gethrtime(); | ||
| } | ||
|
|
||
| function end_test($start, $name, $overhead = null) | ||
| { | ||
| global $total; | ||
| global $last_time; | ||
| $end = gethrtime(); | ||
| ob_end_clean(); | ||
| $last_time = $end-$start; | ||
| $total += $last_time; | ||
| $num = number_format($last_time,3); | ||
| $pad = str_repeat(" ", 24-strlen($name)-strlen($num)); | ||
| if (is_null($overhead)) { | ||
| echo $name.$pad.$num."\n"; | ||
| } else { | ||
| $num2 = number_format($last_time - $overhead,3); | ||
| echo $name.$pad.$num." ".$num2."\n"; | ||
| } | ||
| ob_start(); | ||
| return gethrtime(); | ||
| } | ||
|
|
||
| function total() | ||
| { | ||
| global $total; | ||
| $pad = str_repeat("-", 24); | ||
| echo $pad."\n"; | ||
| $num = number_format($total,3); | ||
| $pad = str_repeat(" ", 24-strlen("Total")-strlen($num)); | ||
| echo "Total".$pad.$num."\n"; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much is this a problem - without it, will it corrupt something? Backtraces does normally create a CoW copy [1], so removing this condition can improve performance.
[1] https://3v4l.org/nbiOF/rfc#vgit.master_jit and https://3v4l.org/gSHDb/rfc#vgit.master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not cause memory corruption, but causes a semantic change.
Let's say you remove the condition, then the following can happen:
If you have
$a = array_merge($a, ...);where $a is an argument, and the call causes an exception, then $a will be NULL in the backtrace because its value has been moved into the function call argument.