-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix negative indices on empty array don't affect next chosen index #11157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
eae6b6f
Changed the default value of nNextFreeElement in _zend_empty_array fr…
ColinHDev fbd798b
Mentioned the change in UPGRADING file
ColinHDev 68641ed
Added test file
ColinHDev 20970e0
Renamed test file
ColinHDev 38e2f03
Removed copy-pasted line from test file
ColinHDev 7b671d8
Applying requested changes
ColinHDev 1a13270
I somehow accidentally removed this space
ColinHDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--TEST-- | ||
Test empty arrays with first added index being negative | ||
--FILE-- | ||
<?php | ||
|
||
$a = array(); | ||
ColinHDev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
$a[-5] = "-5"; | ||
$a[] = "after -5"; | ||
|
||
var_dump($a); | ||
?> | ||
--EXPECT-- | ||
array(2) { | ||
[-5]=> | ||
string(2) "-5" | ||
[-4]=> | ||
string(8) "after -5" | ||
} | ||
ColinHDev marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.