Skip to content

ext/pdo_firebird: Use new zend_string_starts_with_*_ci() API #11049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Apr 10, 2023

No description provided.

@nielsdos
Copy link
Member

I think this looks right, but I think this is actually a bugfix rather than a refactor.
Let's say param->name is "abc", and var->aliasname = "abcd". Then the old code will call strncasecmp("abc", "abcd", 3); which returns 0, so then the branch will be taken even though the names don't match?

@Girgias
Copy link
Member Author

Girgias commented Apr 10, 2023

TBH I'm not exactly sure what it is trying to do, it may as well make more sense to use: zend_string_equals_cstr()

@nielsdos
Copy link
Member

TBH I'm not exactly sure what it is trying to do

Binding a named parameter in a prepared statement

Idk whether Firebird considers named parameters case sensitive or not though

@Girgias
Copy link
Member Author

Girgias commented Apr 10, 2023

Windows failure is legit, need to investigate.

@Girgias Girgias force-pushed the insensitive-zend_string-api-usage branch from 9fecb76 to ec8ded8 Compare April 12, 2023 14:18
@Girgias Girgias requested a review from SakiTakamachi as a code owner April 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants