Skip to content

feat: enable Zend Max Execution Timers by default in 8.3 #10778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2023
Merged

feat: enable Zend Max Execution Timers by default in 8.3 #10778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf8dfe3
feat: enable Zend Max Execution Timers by default in 8.3
dunglas Mar 4, 2023
85f022f
add supression
dunglas Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/lsan-suppressions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
leak:acommon::DictInfoList::elements
leak:timer_create
2 changes: 2 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ PHP NEWS
. Fix bug GH-8821 (Improve line numbers for errors in constant expressions).
(ilutov)
. Fix bug GH-10083 (Allow comments between & and parameter). (ilutov)
. Zend Max Execution Timers is now enabled by default for ZTS builds on
Linux. (Kévin Dunglas)

- Date:
. Implement More Appropriate Date/Time Exceptions RFC. (Derick)
Expand Down
2 changes: 2 additions & 0 deletions UPGRADING
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ PHP 8.3 UPGRADE NOTES
Internally, this works by caching the result on posix systems. If you want
the old behaviour, you can check the "cached" key in the array returned by
proc_get_status() to check whether the result was cached.
. Zend Max Execution Timers is now enabled by default for ZTS builds on
Linux.

- FFI:
. C functions that have a return type of void now return null instead of
Expand Down
2 changes: 1 addition & 1 deletion Zend/Zend.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ AC_ARG_ENABLE([zend-max-execution-timers],
[AS_HELP_STRING([--enable-zend-max-execution-timers],
[whether to enable zend max execution timers])],
[ZEND_MAX_EXECUTION_TIMERS=$enableval],
[ZEND_MAX_EXECUTION_TIMERS='no'])
[ZEND_MAX_EXECUTION_TIMERS=$ZEND_ZTS])

AS_CASE(["$host_alias"], [*linux*], [], [ZEND_MAX_EXECUTION_TIMERS='no'])

Expand Down