Use zend_result in ext/spl where appropriate #10734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
approved these changes
Feb 28, 2023
TimWolla
reviewed
Mar 1, 2023
Comment on lines
+82
to
+84
| e. ext/spl | ||
| - The PHPAPI spl_iterator_apply() function now returns zend_result instead of int. | ||
| There are no functional changes. |
There was a problem hiding this comment.
If there are no functional changes, does this require a mention in the UPGRADING notes?
There was a problem hiding this comment.
I don't know. I thought it was best to document it since it seems to be a public API. If it shouldn't be documented I can drop this change.
There was a problem hiding this comment.
Probably not since conversion from and to int is fine (without specific strict flags). But it doesn't really hurt either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked ext/spl and I found some places where zend_result can be returned instead of int.