Fix GCC 12 compiler warnings #10713
Merged
Fix GCC 12 compiler warnings #10713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However, this code looks really sketchy...
Add void to our bundled libraries
Fix -Wdeprecated-non-prototype compiler warnings Use bool instead of char/int Cleanup some useless header includes
|
I checked if there are any accidental semantic changes and I think it's okay in that respect. :) |
iluuu1994
reviewed
Feb 26, 2023
| @@ -673,12 +673,11 @@ static int mysqlnd_zval_array_to_mysqlnd_array(zval *in_array, MYSQLND ***out_ar | |||
| /* }}} */ | |||
|
|
|||
| /* {{{ mysqlnd_zval_array_from_mysqlnd_array */ | |||
| static int mysqlnd_zval_array_from_mysqlnd_array(MYSQLND **in_array, zval *out_array) | |||
| static zend_result mysqlnd_zval_array_from_mysqlnd_array(MYSQLND **in_array, zval *out_array) | |||
There was a problem hiding this comment.
The result value of mysqlnd_zval_array_from_mysqlnd_array is never read, should we also drop it?
There was a problem hiding this comment.
Probably, or start using the return value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally upgraded to Fedora 37 and GCC got updated to GCC 12.2 which greeted me with some new compiler warnings.
While I was at it I decided to improve BC Math but there is still a lot to do and might make sense to split into a seperate PR.