New test case from ed0c0df351 exercises the code it was intended to #10666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ed0c0df, Niels Dossche fixed a bug in mbstring whereby mb_convert_encoding could dereference a NULL pointer and crash if it was called on an array, with multiple candidate encodings, and at least one of the strings inside the array was invalid in all the candidate encodings. He kindly included a test case, but after being merged into master, the test case was not actually testing what it was intended to test. That is now fixed.
|
This looks good to me, thank you! |
Girgias
approved these changes
Feb 22, 2023
|
Landed, thanks very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ed0c0df, Niels Dossche fixed a bug in mbstring whereby mb_convert_encoding could dereference a NULL pointer and crash if it was called on an array, with multiple candidate encodings, and at least one of the strings inside the array was invalid in all the candidate encodings.
He kindly included a test case, but after being merged into master, the test case was not actually testing what it was intended to test. That is now fixed.
As discussed in #10628.
@Girgias @nielsdos