Skip to content

[ci skip] NEWS #10586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2023
Merged

[ci skip] NEWS #10586

merged 1 commit into from
Feb 14, 2023

Conversation

nielsdos
Copy link
Member

No description provided.

@TimWolla
Copy link
Member

To correctly merge this upwards: This refers to #10458?

@nielsdos
Copy link
Member Author

To correctly merge this upwards: This refers to #10458?

Yes

@TimWolla TimWolla merged commit e35e6dc into php:PHP-8.1 Feb 14, 2023
TimWolla added a commit that referenced this pull request Feb 14, 2023
* PHP-8.1:
  [ci skip] NEWS (#10586)
  [ci skip] Next release will be 8.0.29
TimWolla added a commit that referenced this pull request Feb 14, 2023
* PHP-8.2:
  [ci skip] NEWS (#10586)
  [ci skip] Next release will be 8.0.29
@nielsdos
Copy link
Member Author

Thank you!

@TimWolla
Copy link
Member

FWIW: For my own PRs with ext/random fixes that don't have an associated issue (i.e. the only thing is the PR), I just tend to use the PR number within NEWS, e.g.

php-src/NEWS

Line 52 in 36d55f8

. Fixed bug GH-10247 (Theoretical file descriptor leak for /dev/urandom). (timwolla)

@nielsdos
Copy link
Member Author

Okay I'll do that in the future, thanks for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants