Skip to content

Remove unbalanced parentheses in an error message #10420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Remove unbalanced parentheses in an error message #10420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/standard/link.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ PHP_FUNCTION(readlink)

if (ret == -1) {
#ifdef PHP_WIN32
php_error_docref(NULL, E_WARNING, "readlink failed to read the symbolic link (%s), error %d)", link, GetLastError());
php_error_docref(NULL, E_WARNING, "readlink failed to read the symbolic link (%s), error %d", link, GetLastError());
#else
php_error_docref(NULL, E_WARNING, "%s", strerror(errno));
#endif
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/file/readlink_realpath_error-win32.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ echo "Done\n";
--EXPECTF--
*** Testing readlink() on a non-existent link ***

Warning: readlink(): readlink failed to read the symbolic link (%s, error %d) in %s on line %d
Warning: readlink(): readlink failed to read the symbolic link (%s), error %d in %s on line %d
bool(false)

*** Testing readlink() on existing file ***
Expand Down
4 changes: 2 additions & 2 deletions ext/standard/tests/file/readlink_realpath_variation2-win32.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ string(%d) "%s%ereadlink_realpath_variation2%ehome%etests%elink%ereadlink_realpa
Warning: symlink(): No such file or directory in %s on line %d
bool(false)

Warning: readlink(): readlink failed to read the symbolic link (%s) in %s on line %d
Warning: readlink(): readlink failed to read the symbolic link (%s), error %d in %s on line %d
bool(false)
bool(false)

Expand All @@ -90,7 +90,7 @@ string(%d) "%s%ereadlink_realpath_variation2%ehome%etests%elink%ereadlink_realpa
Warning: link(): No such file or directory in %s on line %d
bool(false)

Warning: readlink(): readlink failed to read the symbolic link (%s) in %s on line %d
Warning: readlink(): readlink failed to read the symbolic link (%s), error %d in %s on line %d
bool(false)
bool(false)

Expand Down
4 changes: 2 additions & 2 deletions ext/standard/tests/file/rename_variation7-win32.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ echo "Done\n";
--EXPECTF--
Warning: symlink(): No such file or directory in %srename_variation7-win32.php on line %d

Warning: readlink(): readlink failed to read the symbolic link (%srename_variation7-win32.php.tmp.link), error 2) in %srename_variation7-win32.php on line %d
Warning: readlink(): readlink failed to read the symbolic link (%srename_variation7-win32.php.tmp.link), error 2 in %srename_variation7-win32.php on line %d
bool(false)

Warning: readlink(): readlink failed to read the symbolic link (%srename_variation7-win32.php.tmp.link2), error 2) in %srename_variation7-win32.php on line %d
Warning: readlink(): readlink failed to read the symbolic link (%srename_variation7-win32.php.tmp.link2), error 2 in %srename_variation7-win32.php on line %d
bool(false)
Done