include cleanup part 6 #10410
Closed
include cleanup part 6 #10410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Jan 22, 2023
| @@ -434,4 +434,18 @@ END_EXTERN_C() | |||
|
|
|||
| #include "php_reentrancy.h" | |||
|
|
|||
| /* the following headers used to be included indirectly, and we have | |||
| * them here only for backwards compatibility with thirdparty | |||
| * extensions */ | |||
MaxKellermann
force-pushed
the
include_cleanup6
branch
from
e05021f to
4116507
Compare
github-actions
bot
added
Extension: opcache
SAPI: cgi
SAPI: cli
SAPI: fpm
SAPI: phpdbg
labels
|
Rebased & moved a few more non-intrusive commits from #10345 |
MaxKellermann
force-pushed
the
include_cleanup6
branch
2 times, most recently
from
a6c746b to
fa399df
Compare
MaxKellermann
force-pushed
the
include_cleanup6
branch
from
fa399df to
58002e6
Compare
|
All |
MaxKellermann
force-pushed
the
include_cleanup6
branch
from
58002e6 to
dd4d319
Compare
MaxKellermann
force-pushed
the
include_cleanup6
branch
from
dd4d319 to
bc2e058
Compare
These are currently indirectly included, but in order to retain source compatibility with out-of-tree extensions when #includes are cleaned up in those parts of PHP, we need to re-add them to the "php.h" header.
Without this, the macros ZTS, ZEND_DEBUG and PHP_COMPILER_ID may be unavailable.
MaxKellermann
force-pushed
the
include_cleanup6
branch
from
bc2e058 to
6df70c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested on php-internals, this PR contains parts of #10345 that are not so controversial, because they mostly add missing things, but do not remove anything just yet.
One new commit adds compatibility
#includestomain/php.h, because people on php-internals have suggested that source compatibility with third-party extensions should be retained, even if those extensions are buggy (e.g. forgetting to includeerrno.heven though they useerrno). Much of that commit addresses issues that will arise once more includes are cleaned up; it makes those header dependencies explicit, instead of making them accidental and implicit.