Skip to content

Minor conditions simplify #10397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2023
Merged

Minor conditions simplify #10397

merged 3 commits into from
Apr 26, 2023

Conversation

mvorisek
Copy link
Contributor

No description provided.

TimWolla
TimWolla reviewed Jan 21, 2023
View reviewed changes
@mvorisek mvorisek force-pushed the simplify_cond branch 4 times, most recently from ef6f135 to 4db0060 Compare February 2, 2023 23:10
@mvorisek mvorisek marked this pull request as ready for review February 3, 2023 01:10
@mvorisek
Copy link
Contributor Author

mvorisek commented Feb 3, 2023 •
edited
Loading

PR is done.

In #10397 (comment) there was a sudgestion to simplify the freeXxx() calls /wo condition of the pointer is empry or not, I agree, but it is unrelated and should deserve a separate PR across for all files.

Let me know if the changes in run-tests.php needs a separate PR.

@mvorisek mvorisek requested a review from TimWolla February 7, 2023 11:22
TimWolla
TimWolla reviewed Feb 7, 2023
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any opinion on the general premise of simplifying these conditions and did not check whether the performed simplification is correct. However I believe that the unrelated changes to the *.phpt descriptions / typos should not be part of this PR and the same is true for the comment reformatting in php_reflection.c

@mvorisek mvorisek marked this pull request as draft February 7, 2023 18:27
@mvorisek mvorisek marked this pull request as ready for review February 7, 2023 18:31
@mvorisek
Copy link
Contributor Author

mvorisek commented Feb 7, 2023

@TimWolla thank you, the other changes extracted to #10535 and #10536

@mvorisek mvorisek requested a review from bukka as a code owner April 17, 2023 11:17
mvorisek
mvorisek commented Apr 17, 2023
View reviewed changes
@mvorisek
Copy link
Contributor Author

This small PR should be done if nothings needs to be regenerated.

@iluuu1994 iluuu1994 merged commit f89fe83 into php:master Apr 26, 2023
@iluuu1994
Copy link
Member

Thanks @mvorisek

@mvorisek mvorisek deleted the simplify_cond branch April 26, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla left review comments

@iluuu1994 iluuu1994 iluuu1994 left review comments

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: phar SAPI: fpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvorisek @iluuu1994 @TimWolla