Remove php_pdo_mysql_sqlstate.h

[marcosmarcolin]

No description provided.

[cmb69]

Thanks for the PR!

[kamil-tekiela]

I have absolutely no idea what this file was for. I can't find the history in Git now. Maybe the original authors would know. The file is pretty ancient but it was modified 11 years ago.
I'd suggest removing both files and seeing if anyone complains. My guess is that they are not used by PHP anymore. If we learn about where they are used, then we can leave a proper comment in the header file to explain what it's for.

[marcosmarcolin]

@cmb69 @kamil-tekiela

As I understand it: get_error_codes.php is just a script to generate php_pdo_mysql_sqlstate.h with all MySQL error codes. From Git history, this was done for PHP 5.

I looked in the project and found no use for php_pdo_mysql_sqlstate.h, it doesn't call anywhere.

What do you think we remove it and see if it implies anything?

[cmb69]

As I understand it: get_error_codes.php is just a script to generate php_pdo_mysql_sqlstate.h with all MySQL error codes.

Indeed. And it does so from sql_state.h, and it needs to be run manually. It actually might make sense to keep and use that file to check for potential compatibility issues with different MySQL version, and particularly with the different forks we're supporting.

On the other hand, it seems that php_pdo_mysqlstate.h is unused, so it should be removed as well (plus its mention in CONTRIBUTING.md).

[kamil-tekiela]

Also, no idea how to get sql_state.h as this file doesn't seem to be available anymore and I could not find any trace of it online.

[cmb69]

I found it here; but like I said, if php_pdo_mysqlstate.h is unused, we don't need a script to keep it up to date.

[marcosmarcolin]

@cmb69 I removed the files and updated CONTRIBUTING.md.

Check if it's what you want.

[cmb69]

Yes, that looks good to me. Thank you!

Is this fine for you, too, @kamil-tekiela?

[kamil-tekiela]

Yes, it looks good.

[marcosmarcolin]

Thanks for the direction! @cmb69 @kamil-tekiela