Skip to content

Remove mysqlnd_shutdown() #10355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2023
Merged

Remove mysqlnd_shutdown() #10355

merged 1 commit into from
Jan 17, 2023

Conversation

kamil-tekiela
Copy link
Member

MySQL has deprecated and removed this command. https://dev.mysql.com/worklog/task/?id=9014
I found no information about MariaDB, but in line with MySQL I propose to remove this method. We are not using it in mysqli or PDO_MySQL.

Girgias
Girgias approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, @cmb69 your opinion?

cmb69
cmb69 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I have no idea if that method might be used by some mysqlnd extension, but I think we only can find out, if we remove the function, and given there is a nice note in UPGRADING.INTERNALS, this looks good to me.

@kamil-tekiela kamil-tekiela merged commit 0e5128c into php:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: mysqlnd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamil-tekiela @cmb69 @Girgias