Skip to content

Mark constant static arrays in function bodies actually as const #10325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2023
Merged

Mark constant static arrays in function bodies actually as const #10325

merged 1 commit into from
Jan 15, 2023

Conversation

nielsdos
Copy link
Member

These arrays are not meant to be modified, mark them as const.
This prevents accidental modification and places the arrays in .rodata.

@nielsdos nielsdos force-pushed the const-arrays-in-functions branch from 543134f to 4349f02 Compare January 15, 2023 00:19
devnexen
devnexen approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good changes to me cc @Girgias

@Girgias Girgias merged commit a60c6ee into php:master Jan 15, 2023
@nielsdos nielsdos deleted the const-arrays-in-functions branch January 15, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Category: Engine Extension: hash Extension: iconv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsdos @devnexen @Girgias