ext/opcache/jit/zend_jit: fix inverted bailout value in zend_runtime_jit() #10144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jit() In the "catch" block, do_bailout must be set to true, not false, or else zend_bailout() never gets called.
devnexen
reviewed
Dec 21, 2022
| @@ -4287,7 +4287,7 @@ static int ZEND_FASTCALL zend_runtime_jit(void) | |||
| /* perform real JIT for this function */ | |||
| zend_real_jit_func(op_array, NULL, NULL); | |||
| } zend_catch { | |||
| do_bailout = 0; | |||
| do_bailout = true; | |||
There was a problem hiding this comment.
could you set to false above for consistency ? your changes looks good otherwise.
There was a problem hiding this comment.
I'm going to submit a master branch PR with lots of bool cleanup - no code change, just semantic cleanup - but wanted this bug fix PR to be as small/simple as possible, only fixing the actual bug.
There was a problem hiding this comment.
ah if that s the case, makes sense then.
|
Thank you! |
arnaud-lb
added a commit
that referenced
this pull request
Dec 21, 2022
* PHP-8.1: [ci skip] NEWS ext/opcache/jit/zend_jit: fix inverted bailout value in zend_runtime_jit() (#10144)
arnaud-lb
added a commit
that referenced
this pull request
Dec 21, 2022
* PHP-8.2: [ci skip] NEWS [ci skip] NEWS ext/opcache/jit/zend_jit: fix inverted bailout value in zend_runtime_jit() (#10144)
MaxKellermann
added a commit
to CM4all/php-src
that referenced
this pull request
Jan 9, 2023
…jit() (php#10144) In the "catch" block, do_bailout must be set to true, not false, or else zend_bailout() never gets called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "catch" block, do_bailout must be set to true, not false, or else zend_bailout() never gets called.