Skip to content

Fix compilation on RHEL 7 ppc64le (gcc 4.8) #10078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix compilation on RHEL 7 ppc64le (gcc 4.8) #10078

wants to merge 1 commit into from

Conversation

oerdnj
Copy link
Contributor

@oerdnj oerdnj commented Dec 10, 2022

Closes #10077

iluuu1994
iluuu1994 approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this target the PHP-8.2 branch?

@oerdnj
Copy link
Contributor Author

oerdnj commented Dec 11, 2022

Shouldn't this target the PHP-8.2 branch?

I think this needs to go both to main (future PHP-8.3, right?) and PHP-8.2 branch.

@oerdnj
Copy link
Contributor Author

oerdnj commented Dec 11, 2022

FTR I pulled the patch directly from upstream and confirmed this fixes the Ubuntu 18.04 ppc64el build.

@iluuu1994
Copy link
Member

@oerdnj Yes, for those cases we merge into the lowest necessary branch and then merge upstream. But it's fine, I can fix this while merging. 🙂

@iluuu1994 iluuu1994 closed this in a839230 Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
Extension: hash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FTBFS PHP 8.2 on Ubuntu 18.04 ppc64el
3 participants
@oerdnj @iluuu1994 @ellert