Remove _zend_ast_decl->lex_pos #10046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This struct member was only written to, but never read.
iluuu1994
reviewed
Dec 3, 2022
There was a problem hiding this comment.
This might be used in extensions. A quick search on SourceGraph revealed nothing though.
Note that zend_ast_decl are only used for declarations, whereas zend_ast is mainly used. So the difference is likely negligible.
|
Thank you for the review. |
|
I asked for opinions in our internal chat. I'll get back to you. IMO it would be fine to remove this in |
|
It's fine to drop this. We used to make use of this for RTD key generation, but this is handled differently now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This struct member was only written to, but never read.
On Linux x86-64, this shrinks
_zend_ast_declfrom 80 bytes to 72 bytes.