strtok warns in case the string to split was not set.

[devnexen]

No description provided.

[cmb69]

strtok() is a terrible API, and I think this warning improves it a bit. I'm not sure about the wording of the message ("First call must set the string argument"); while this is usually correct, the adjustments to the existing tests are somewhat confusing. Maybe the problem is that the tests are written with for-loops instead of while-loops, but maybe we should change the message to something like "No string argument to tokenize set"?

[devnexen]

strtok() is a terrible API, and I think this warning improves it a bit

It s likely more confusing for pure php devs I think, just trying to clarify a bit the "quirks" behind :)
I do not mind changing the wording if needs be, let s see what @kocsismate think.

[kocsismate]

I'm fine with either error messages... as long as no string user input is exposed (ZSTR_VAL(tok)). :)

Just my 2c:
Both arguments must be provided when calling strtok() the first time

I'm really not sure which version is the best :)

[kocsismate]

Ok, the "first time" isn't really appropriate because the parameter must be provided whenever there is a new tokenization starting, so: Both arguments must be provided when starting tokenization

[devnexen]

oky doky.

[kocsismate]

Looks fine for me! Feel free to merge If @cmb69 is also satisfied with the error message :)

[cmb69]

Yeah, I like this error message! Thank you!