Skip to content

intl extension: msgfmt_set_pattern add pattern format error informati… #10006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

…ons.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a nice improvement, and besides the nits below, looks good to me.

@devnexen devnexen force-pushed the intl_msg_set_pattern_err branch from 90791fa to 35c6f49 Compare December 9, 2022 15:52
devnexen added a commit to devnexen/php-src that referenced this pull request Dec 9, 2022
@devnexen
Copy link
Member Author

devnexen commented Dec 9, 2022

Closes with 6422cf6

@devnexen devnexen closed this Dec 9, 2022
devnexen added a commit that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants