Skip to content

Fix null pointer dereference in zend_get_executed_lineno() #10003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2022
Merged

Fix null pointer dereference in zend_get_executed_lineno() #10003

merged 1 commit into from
Dec 2, 2022

Conversation

arnaud-lb
Copy link
Member

Fixes #9933

@arnaud-lb
Fallback to first line of function when ex->opline is NULL
7e3eb14 
This can happen due to missing SAVE_OPLINE() in the VM
@arnaud-lb arnaud-lb changed the base branch from master to PHP-8.1 November 26, 2022 15:15
@arnaud-lb arnaud-lb mentioned this pull request Nov 26, 2022
Closed
@arnaud-lb arnaud-lb marked this pull request as ready for review December 2, 2022 11:58
@arnaud-lb arnaud-lb requested review from bwoebi and iluuu1994 December 2, 2022 11:59
iluuu1994
iluuu1994 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@arnaud-lb arnaud-lb merged commit adc2382 into php:PHP-8.1 Dec 2, 2022
arnaud-lb added a commit to arnaud-lb/php-src that referenced this pull request Dec 2, 2022
@arnaud-lb
Merge branch 'PHP-8.1' into PHP-8.2
1c3e860 
* PHP-8.1:
  [ci skip] NEWS
  Fallback to first line of function when ex->opline is NULL (php#10003)
arnaud-lb added a commit to arnaud-lb/php-src that referenced this pull request Dec 2, 2022
@arnaud-lb
Merge branch 'PHP-8.2'
28c0775 
* PHP-8.2:
  [ci skip] NEWS
  [ci skip] NEWS
  Fallback to first line of function when ex->opline is NULL (php#10003)
cmb69 added a commit that referenced this pull request Dec 5, 2022
@cmb69
Merge branch 'PHP-8.1' into PHP-8.2
b683a7e 
* PHP-8.1:
  Fallback to first line of function when ex->opline is NULL (#10003)
cmb69 added a commit that referenced this pull request Dec 5, 2022
@cmb69
Merge branch 'PHP-8.2'
6109b80 
* PHP-8.2:
  Fallback to first line of function when ex->opline is NULL (#10003)
@cmb69
Copy link
Member

cmb69 commented Dec 5, 2022

Please don't forget to merge upwards next time. :)

@arnaud-lb
Copy link
Member Author

Oh, I think that I forgot to push. Sorry for the inconvenience, thank you for doing it!

nielsdos pushed a commit to nielsdos/php-src that referenced this pull request Dec 12, 2022
@arnaud-lb @nielsdos
Fallback to first line of function when ex->opline is NULL (php#10003)
7a401c1 
ex->opline can be null due to missing SAVE_OPLINE() in the VM

Fixes phpGH-9933
@nielsdos nielsdos mentioned this pull request Nov 10, 2023
Closed
@nielsdos nielsdos mentioned this pull request Feb 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@bwoebi bwoebi Awaiting requested review from bwoebi

Assignees
No one assigned
Labels
Category: Engine Waiting on Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashes due to ex->opline being null
3 participants
@arnaud-lb @cmb69 @iluuu1994