`ext/ffi/tests/300.phpt` test is failing on Alpine linux

[mvorisek]

Description

CI output:

 ========DIFF========
+001+ Mon Jul 25 18:27:07 2022 (140065768821768): Fatal Error "opcache.preload_user" has not been defined
-001- Hello World from PHP!
 ========DONE========
 FAIL FFI 300: FFI preloading [ext/ffi/tests/300.phpt] 

CI: https://github.com/php/php-src/runs/7506106345?check_suite_focus=true#step:10:739

how can be this test fixed?

PHP Version

master, all other FFI tests pass

Operating System

Alpine linux

[cmb69]

This test has a skipif clause which checks the opcache.preload_user is not empty. I have no idea why that doesn't skip the test.

[mvorisek]

Yes, but it skips the test if the opcache.preload_user is non-empty. @dstogov you are the author of the test, can you please have a look?

[arnaud-lb]

Looking at the code, this error is triggered when running as root and opcache.preload_user was not defined. According to the doc, opcache.preload_user must be defined when running as root.

We could clarify the error message.

[cmb69]

Would it also be possible to run the tests on Alpine as regular user?

[mvorisek]

I searched all occurences of opcache.preload_user in tests and ext/ffi/tests/bug78761.phpt test does not fail. It is because ffi.enable=1 is not defined there?

Would it also be possible to run the tests on Alpine as regular user?

We can. Why is opcache.preload_user actually so dangerous to require non root user? In Docker, it is very common to run everything as root and rely on Docker isolation. So maybe such arbitrary limitation should be removed complete.

[KapitanOczywisty]

We can. Why is opcache.preload_user actually so dangerous to require non root user?

Seems like opcache.preload_user do not require non-root user.

php-src/.cirrus.yml

Lines 23 to 24 in fdb9e3a

	# Specify opcache.preload_user as we're running as root.
	- echo opcache.preload_user=root >> /etc/php.d/opcache.ini

[arnaud-lb]

Adding opcache.preload_user yields a new error:

Fatal error: Uncaught FFI\Exception: FFI::load() doesn't work in conjunction with "opcache.preload_user". Use "ffi.preload" instead.

We should skip this test when ran as root.

I also think that we should execute tests as a non root user.

I searched all occurences of opcache.preload_user in tests and ext/ffi/tests/bug78761.phpt test does not fail. It is because ffi.enable=1 is not defined there?

This test also fails here

[cmb69]

Isn't this resolved via 1c9a49e?

I also think that we should execute tests as a non root user.

ACK