Random extension random.c:95:20: runtime error: shift exponent 32 is too large for 32-bit type 'unsigned int'

[Girgias]

Description

Various SPL tests on master now fail with:

random.c:95:20: runtime error: shift exponent 32 is too large for 32-bit type 'unsigned int'

PHP Version

master

Operating System

Fedora 35

[cmb69]

ext/spl/php_spl.c includes ext/random/php_random.h:

php-src/ext/spl/php_spl.c

Line 39 in 067a302

#include "ext/random/php_random.h"

However, that is apparently not needed for that compilation unit.

[guilliamxavier]

@cmb69 indeed, this line (previously

php-src/ext/spl/php_spl.c

Line 39 in 8fec415

#include "ext/standard/php_mt_rand.h"

) could have been removed in fd8770e (maybe should be now)

But besides that, there's indeed an UB to "fix": #9056 (comment)

[Girgias]

ext/spl/php_spl.c includes ext/random/php_random.h:

php-src/ext/spl/php_spl.c

Line 39 in 067a302

#include "ext/random/php_random.h"

However, that is apparently not needed for that compilation unit.

Removing it doesn't seem to fix the issue in SPL anyway

[guilliamxavier]

Sorry for the noise:

php-src/ext/dom/php_dom.c

Line 25 in f60f6be

#include "ext/random/php_random.h"

(previously

php-src/ext/dom/php_dom.c

Line 25 in 8fec415

#include "ext/standard/php_rand.h"

) seems unneeded too (but there I don't even see why it was added in the first place)

Anyway, removing it won't fix the issue either 😅

[cmb69]

Removing it doesn't seem to fix the issue in SPL anyway

Nope, but #9056 (comment) should.