Skip to content

ext/ldap: Memory leak in php_ldap_do_modify() when entry is not a proper dictionary #16136

Closed
@Girgias

Description

@Girgias

Description

The following code:

<?php

/* ldap_add(_ext)(), ldap_mod_replace(_ext)(), ldap_mod_add(_ext)(), and ldap_mod_del(_ext)() share an underlying C function */
/* We are assuming 3333 is not connectable */
$ldap = ldap_connect('ldap://127.0.0.1:3333');
$valid_dn = "cn=userA,something";

$not_dict_of_attributes = [
    'attribute1' => 'value',
    'not_key_entry',
    'attribute3' => [
        'value1',
        'value2',
    ],
];
try {
    var_dump(ldap_add($ldap, $valid_dn, $not_dict_of_attributes));
} catch (Throwable $e) {
    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}

Resulted in this output:

Warning: ldap_add(): Unknown attribute in the data in %s on line %d
bool(false)
+ Memory leak

But I expected this output instead:

Warning: ldap_add(): Unknown attribute in the data in %s on line %d
bool(false)

PHP Version

PHP 8.2

Operating System

No response

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions