integer overflow tm2unixtime.c:464:13

[chongwick]

Description

The following code:

<?php
$vars = array(
        "DateTime"                       => new DateTime(),);
$vars["DateTime"]->setDate(PHP_INT_MAX, 2, PHP_INT_MIN);
?>

Resulted in this output:

/home/dan/php-8.3.9/ext/date/lib/tm2unixtime.c:464:13: runtime error: signed integer overflow: 22995298254817523 * 146097 cannot be represented in type 'long long int'

But I expected this output instead:

PHP Version

8.3.9

Operating System

No response

[SakiTakamachi]

hmm...

php-src/ext/date/lib/tm2unixtime.c

Line 464 in a47d823

return era * DAYS_PER_ERA + day_of_era - HINNANT_EPOCH_SHIFT;

I've investigated this a bit, but so far I can't think of a simple way to solve this problem without making direct changes to the library. The calculations performed by the library are slightly complex, and it seems like a waste to perform similar calculations in advance to detect overflows...

I'm not familiar with this library, is it allowed to modify it directly?

cc: @derickr