Unnecessary include in main.c bloats binary

[determin1st]

Description

i was reducing some of standard/html feature and found a big html_tables.h that is autogenerated is included here

php-src/main/main.c

Line 86 in fde34bc

#include "ext/standard/html_tables.h"

but those tables arent used in main.c, only some functions from html are called. shouldnt it be removed to reduce binary size?

[nielsdos]

Nice find. I think you're right.
This include was added in 418f974 for the get_safe_charset_hint function that was added in the same commit. This function was removed in c50cfc4 but the include remained.
Dropping the include still results in a working compilation, so I think we can just drop this. Although we're late in the 8.4 development cycle so we must remain careful.

[cmb69]

Hmm, it seems the header is still needed for html.c.

[determin1st]

Hmm, it seems the header is still needed for html.c.

aa-absolutely, those tables are used in there for transcoding html entities back and forth. ive removed html5 tables and charsets, as soon as i assume everything must be UTF8 for my CLI version.

[nielsdos]

Hmm, it seems the header is still needed for html.c.

I only meant dropping the include from the main.c file.

[cmb69]

I only meant dropping the include from the main.c file.

Okay. I think we still can do that PHP 8.4. The file should probably never have been included in anything else but html.c, and probably not be installed, but that's another story.