Build with libxml2 versions 2.9.0 to 2.9.3 fails

[petk]

Description

The following code:

./buildconf
./configure
make

Resulted in this output:

In file included from /libxml2.9.3/usr/local/include/libxml2/libxml/tree.h:333,
                 from /libxml2.9.3/usr/local/include/libxml2/libxml/dict.h:16,
                 from /php-src/ext/dom/lexbor/lexbor/selectors-adapted/selectors.c:10:
/libxml2.9.3/usr/local/include/libxml2/libxml/xmlregexp.h:123:42: error: unknown type name ‘xmlDictPtr’
  123 |                                          xmlDictPtr dict);
      |                                          ^~~~~~~~~~
In file included from /libxml2.9.3/usr/local/include/libxml2/libxml/parser.h:18,
                 from /libxml2.9.3/usr/local/include/libxml2/libxml/globals.h:18,
                 from /libxml2.9.3/usr/local/include/libxml2/libxml/threads.h:35,
                 from /libxml2.9.3/usr/local/include/libxml2/libxml/xmlmemory.h:218,
                 from /libxml2.9.3/usr/local/include/libxml2/libxml/tree.h:1307:
/libxml2.9.3/usr/local/include/libxml2/libxml/hash.h:110:42: error: unknown type name ‘xmlDictPtr’; did you mean ‘xmlDocPtr’?
  110 |                                          xmlDictPtr dict);
      |                                          ^~~~~~~~~~
      |                                          xmlDocPtr
/libxml2.9.3/usr/local/include/libxml2/libxml/parser.h:263:5: error: unknown type name ‘xmlDictPtr’
  263 |     xmlDictPtr         dict;          /* dictionnary for the parser */
      |     ^~~~~~~~~~

But I expected this output instead:

Successful build

There seems to be a change done in libxml2 2.9.4 version in <libxml/dict.h> file where the xmlDictPtr type was added before other includes so the <libxml/dict.h> can be included directly. In PHP 8.3 it works ok. PHP 8.4 with libxml2 2.9.4 also works ok. Perhaps some more includes need to be done before dict.h?

PHP Version

PHP 8.4

Operating System

Linux

[cmb69]

I think we should bump the requirements to libxml2 2.9.4 anyway, since that version fixed a lot of CVEs. And while some distros may have applied these fixes to older versions, 2.9.4 had been relesed on May 23, 2016, so quite a while ago.

cc @nielsdos

[petk]

Bumping these versions at this point is a bit late but I guess we can bump it. Otherwise, installing libxml 2.9.4 on Solaris 10 is not a trivial task at all.

[cmb69]

Otherwise, installing libxml 2.9.4 on Solaris 10 is not a trivial task at all.

That is not nice, but according to Wikipedia, Solaris 10 support ends in January 2027, while PHP 8.3 is supported until end of 2027, so Solaris 10 users can stick with PHP 8.3, until they should upgrade (or switch) anyway.

[nielsdos]

Otherwise, installing libxml 2.9.4 on Solaris 10 is not a trivial task at all.

That's unfortunate :(
Do you recall what happened?

In any case, installing old libxml versions on my system isn't trivial either ;P

[petk]

I've managed to install libxml 2.9.14 now. Issue is mostly Autotools and lot's of errors. Outdated configure.ac - the usual issues. And then on the make install step you need to manually add the built .so libraries to the destination directory.

[nielsdos]

Thanks! So similar issues that I face when building the old versions on my rolling release system :P
I don't think that's that big of a deal for us to bump it then.