Segmentation fault (core dumped) in ext/pgsql/tests/gh13519.phpt

[petk]

Description

The following code:

./buildconf
./configure --with-pgsql
make
./sapi/cli/php run-tests.php --show-diff ext/pgsql/tests/gh13519.phpt

Resulted in this output:

========DIFF========
     bool(true)
     bool(true)
     bool(true)
004- bool(false)
005- bool(false)
006- bool(false)
004+ Segmentation fault (core dumped)
005+ 
006+ Termsig=11
========DONE========
FAIL GH-13519 - PGSQL_CONNECT_FORCE_NEW with persistent connections. [ext/pgsql/tests/gh13519.phpt] 

But I expected this output instead:

PASS GH-13519 - PGSQL_CONNECT_FORCE_NEW with persistent connections. [ext/pgsql/tests/gh13519.phpt] 

• PostgreSQL 16.3

Unless, I've missed something here.

PHP Version

PHP 8.4

Operating System

Ubuntu 24.04

[devnexen]

cannot reproduce locally (ubuntu 24.04 like you), can you provide a backtrace and/or adding --enable-address-sanitizer --enable-debug to configure please ?

[petk]

Hm, I'll see what to do with the backtrace. I somehow cannot get it and I have no idea why. I guess I need to read the docs and adjust that ulimit. Interesting is that when using the --enable-address-sanitizer this doesn't happen.

[petk]

Ok, I think this is it then:

Starting program: php-src/sapi/cli/php ext/pgsql/tests/gh13519.php
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
warning: could not find '.gnu_debugaltlink' file for /lib/x86_64-linux-gnu/liblber.so.2
bool(true)
bool(true)
bool(true)

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7b34a38 in ?? () from /lib/x86_64-linux-gnu/libpq.so.5
(gdb) bt
#0  0x00007ffff7b34a38 in ?? () from /lib/x86_64-linux-gnu/libpq.so.5
#1  0x00007ffff7b35d54 in PQmakeEmptyPGresult () from /lib/x86_64-linux-gnu/libpq.so.5
#2  0x00007ffff7b3978c in ?? () from /lib/x86_64-linux-gnu/libpq.so.5
#3  0x00007ffff7b409b4 in PQgetResult () from /lib/x86_64-linux-gnu/libpq.so.5
#4  0x000055555588fa04 in pgsql_link_free (link=0x7ffff4403150) at php-src/ext/pgsql/pgsql.c:179
#5  0x000055555588fb0e in pgsql_link_free_obj (obj=0x7ffff4403170) at php-src/ext/pgsql/pgsql.c:205
#6  0x0000555555cf8b9f in zend_objects_store_del (object=0x7ffff4403170) at php-src/Zend/zend_objects_API.c:194
#7  0x0000555555d1a812 in rc_dtor_func (p=0x7ffff4403170) at php-src/Zend/zend_variables.c:57
#8  0x0000555555bf1113 in zend_assign_to_variable (variable_ptr=0x7ffff44170b0, value=0x7ffff44171a0, value_type=4 '\004', strict=false)
    at php-src/Zend/zend_execute.h:175
#9  0x0000555555c77f4b in ZEND_ASSIGN_SPEC_CV_VAR_RETVAL_UNUSED_HANDLER () at php-src/Zend/zend_vm_execute.h:49310
#10 0x0000555555c898b9 in execute_ex (ex=0x7ffff4417020) at php-src/Zend/zend_vm_execute.h:63475
#11 0x0000555555c8a156 in zend_execute (op_array=0x7ffff448b000, return_value=0x0) at php-src/Zend/zend_vm_execute.h:64011
#12 0x0000555555d26ae4 in zend_execute_script (type=8, retval=0x0, file_handle=0x7fffffffc9d0) at php-src/Zend/zend.c:1913
#13 0x0000555555ad4cc9 in php_execute_script_ex (primary_file=0x7fffffffc9d0, retval=0x0) at php-src/main/main.c:2535
#14 0x0000555555ad4e4f in php_execute_script (primary_file=0x7fffffffc9d0) at php-src/main/main.c:2575
#15 0x0000555555d28edf in do_cli (argc=2, argv=0x555556e78d60) at php-src/sapi/cli/php_cli.c:956
#16 0x0000555555d29c28 in main (argc=2, argv=0x555556e78d60) at php-src/sapi/cli/php_cli.c:1330

[devnexen]

Thanks would you mind running it again then typing f 4, p link ?

[petk]

(gdb) f 4
#4  0x00005555557d524d in pgsql_link_free (link=link@entry=0x7ffff44030f0) at php-src/ext/pgsql/pgsql.c:179
179		while ((res = PQgetResult(link->conn))) {
(gdb) p link
$1 = (pgsql_link_handle *) 0x7ffff44030f0

[petk]

When using libpq 17 beta 2 (or 18devel):

Starting program: php-src/sapi/cli/php ext/pgsql/tests/gh13519.php
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
bool(true)
bool(true)
bool(true)

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7b348c0 in dupEvents () from postgresql_17-beta2/usr/local/pgsql/lib/libpq.so.5
(gdb) bt
#0  0x00007ffff7b348c0 in dupEvents () from postgresql_17-beta2/usr/local/pgsql/lib/libpq.so.5
#1  0x00007ffff7b357ab in PQmakeEmptyPGresult () from postgresql_17-beta2/usr/local/pgsql/lib/libpq.so.5
#2  0x00007ffff7b364c1 in pqPrepareAsyncResult () from postgresql_17-beta2/usr/local/pgsql/lib/libpq.so.5
#3  0x00007ffff7b3810b in PQgetResult () from postgresql_17-beta2/usr/local/pgsql/lib/libpq.so.5
#4  0x00005555557d52dd in pgsql_link_free (link=link@entry=0x7ffff50030f0) at php-src/ext/pgsql/pgsql.c:179
#5  0x00005555557d5388 in pgsql_link_free_obj (obj=0x7ffff5003110) at php-src/ext/pgsql/pgsql.c:205
#6  0x0000555555a44974 in zend_objects_store_del (object=0x7ffff5003110) at php-src/Zend/zend_objects_API.c:194
#7  0x00005555559f2d68 in zend_assign_to_variable (strict=<optimized out>, value_type=4 '\004', value=<optimized out>, variable_ptr=<optimized out>)
    at php-src/Zend/zend_execute.h:175
#8  ZEND_ASSIGN_SPEC_CV_VAR_RETVAL_UNUSED_HANDLER () at php-src/Zend/zend_vm_execute.h:49310
#9  0x00005555559fd9a3 in execute_ex (ex=0x7ff01c200010) at php-src/Zend/zend_vm_execute.h:63475
#10 0x0000555555a05710 in zend_execute (op_array=op_array@entry=0x7ffff508e000, return_value=return_value@entry=0x0)
    at php-src/Zend/zend_vm_execute.h:64011
#11 0x0000555555a622da in zend_execute_script (type=type@entry=8, retval=retval@entry=0x0, file_handle=file_handle@entry=0x7fffffffc990)
    at php-src/Zend/zend.c:1913
#12 0x0000555555900598 in php_execute_script_ex (primary_file=<optimized out>, retval=retval@entry=0x0) at php-src/main/main.c:2535
#13 0x000055555590080b in php_execute_script (primary_file=<optimized out>) at php-src/main/main.c:2575
#14 0x0000555555a63de8 in do_cli (argc=2, argv=0x555556c37830) at php-src/sapi/cli/php_cli.c:956
#15 0x000055555564ac74 in main (argc=2, argv=0x555556c37830) at php-src/sapi/cli/php_cli.c:1330
(gdb) f 4
#4  0x00005555557d52dd in pgsql_link_free (link=link@entry=0x7ffff50030f0) at php-src/ext/pgsql/pgsql.c:179
179		while ((res = PQgetResult(link->conn))) {
(gdb) p link
$1 = (pgsql_link_handle *) 0x7ffff50030f0

[devnexen]

sorry I meant p link->conn

[petk]

libpq 16 (the one from the above f 4 and p link step)

(gdb) p link->conn
$2 = (PGconn *) 0x555556e8fe10

[devnexen]

I can t reproduce but ... valgrind warns around those same lines. it ll easier to debug with my own postgresql/libpq build.