Misleading error reporting when using a non-existent constant in a static variable initializer

[TimWolla]

Description

The following code (https://3v4l.org/la8tX):

<?php

final class Foo {
    public static $foo = [
        'foo' => DOES_NOT_EXIST,
    ];
}

new Foo();

Resulted in this output:

Fatal error: Uncaught Error: Undefined constant "DOES_NOT_EXIST" in /in/la8tX:9
Stack trace:
#0 {main}
  thrown in /in/la8tX on line 9

But I expected this output instead:

Some indication that the broken constant is in line 5, because line 9 clearly does not contain any constants.

PHP Version

PHP 8.2.1

Operating System

No response

[iluuu1994]

FWIW I started with this a while ago. https://github.com/php/php-src/pull/8855/files The exact type of constant expression is not mentioned but it at least shows the full stack trace.

Edit: Correction, it doesn't show the full constant expression trace but rather the last frame which is the one causing the error.

[TimWolla]

The exact type of constant expression is not mentioned but it at least shows the full stack trace.

Yeah, having the correct line number would've been totally sufficient in my case. When I encountered the issue, the search for the cause was complicated by the fact that the incorrect constant expression was the static variable initializer of the parent class of the class I was instantiating with new. If I was pointed to the correct line, then the cause would've been obvious.

Thanks for the link, I've subscribed that PR.

[TimWolla]

@iluuu1994 I've now tested #8855 with this example. It's much better, thanks! Just one minor thing: The reported line is line 4 (which is where the const expression begins), but the constant is in line 5.

I'm not sure if this is fixable. Feel free to close this issue as resolved if it's not worth it.

[iluuu1994]

@TimWolla Thanks for testing and reporting! The line number should be fixed here now too.