Promote warning to exception in ini_get_all() function

Author: kocsismate

ext/opcache/Optimizer/zend_func_info.c

@@ -363,7 +363,7 @@ static const func_info_t func_infos[] = {
 	F1("highlight_string",             MAY_BE_FALSE | MAY_BE_TRUE | MAY_BE_STRING),
 	F1("php_strip_whitespace",         MAY_BE_STRING),
 	FN("ini_get",                      MAY_BE_FALSE | MAY_BE_STRING),
-	F1("ini_get_all",                  MAY_BE_FALSE | MAY_BE_ARRAY | MAY_BE_ARRAY_KEY_STRING | MAY_BE_ARRAY_OF_NULL | MAY_BE_ARRAY_OF_STRING | MAY_BE_ARRAY_OF_ARRAY),
+	F1("ini_get_all",                  MAY_BE_ARRAY | MAY_BE_ARRAY_KEY_STRING | MAY_BE_ARRAY_OF_NULL | MAY_BE_ARRAY_OF_STRING | MAY_BE_ARRAY_OF_ARRAY),
 	FN("ini_set",                      MAY_BE_FALSE | MAY_BE_STRING),
 	F1("ini_alter",                    MAY_BE_NULL | MAY_BE_FALSE | MAY_BE_STRING),
 	F0("ini_restore",                  MAY_BE_NULL),

ext/standard/basic_functions.c

@@ -3556,7 +3556,7 @@ PHP_FUNCTION(ini_get)
 }
 /* }}} */
 
-/* {{{ proto array|false ini_get_all([string extension[, bool details = true]])
+/* {{{ proto array ini_get_all([string extension[, bool details = true]])
    Get all configuration options */
 PHP_FUNCTION(ini_get_all)
 {
@@ -3567,7 +3567,6 @@ PHP_FUNCTION(ini_get_all)
 	zend_string *key;
 	zend_ini_entry *ini_entry;
 
-
 	ZEND_PARSE_PARAMETERS_START(0, 2)
 		Z_PARAM_OPTIONAL
 		Z_PARAM_STRING_OR_NULL(extname, extname_len)
@@ -3578,8 +3577,8 @@ PHP_FUNCTION(ini_get_all)
 
 	if (extname) {
 		if ((module = zend_hash_str_find_ptr(&module_registry, extname, extname_len)) == NULL) {
-			php_error_docref(NULL, E_WARNING, "Unable to find extension '%s'", extname);
-			RETURN_FALSE;
+			zend_value_error("Unable to find extension '%s'", extname);
+			return;
 		}
 		module_number = module->module_number;
 	}

ext/standard/basic_functions.stub.php

@@ -315,7 +315,7 @@ function highlight_string(string $string, bool $return = false): string|bool|nul
 
 function ini_get(string $varname): string|false {}
 
-function ini_get_all(?string $extension = null, bool $details = true): array|false {}
+function ini_get_all(?string $extension = null, bool $details = true): array {}
 
 function ini_set(string $varname, string $value): string|false {}
 
@@ -361,7 +361,7 @@ function is_uploaded_file(string $path): bool {}
 
 function move_uploaded_file(string $path, string $new_path): bool {}
 
-function parse_ini_file(string $filename, bool $process_sections = false, int $scanner_mode = INI_SCANNER_NORMAL): array|false {}
+function parse_ini_file(string $filename, bool $process_sections = false, int $scanner_mode = INI_SCANNER_NORMAL): array {}
 
 function parse_ini_string(string $ini_string, bool $process_sections = false, int $scanner_mode = INI_SCANNER_NORMAL): array|false {}
 

ext/standard/basic_functions_arginfo.h

@@ -480,7 +480,7 @@ ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ini_get, 0, 1, MAY_BE_STRING|MAY
 	ZEND_ARG_TYPE_INFO(0, varname, IS_STRING, 0)
 ZEND_END_ARG_INFO()
 
-ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ini_get_all, 0, 0, MAY_BE_ARRAY|MAY_BE_FALSE)
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_ini_get_all, 0, 0, IS_ARRAY, 0)
 	ZEND_ARG_TYPE_INFO(0, extension, IS_STRING, 1)
 	ZEND_ARG_TYPE_INFO(0, details, _IS_BOOL, 0)
 ZEND_END_ARG_INFO()

ext/standard/tests/general_functions/ini_get_all.phpt

@@ -10,25 +10,32 @@ pcre.recursion_limit=100000
 <?php
 
 var_dump(gettype(ini_get_all()));
-var_dump(ini_get_all(""));
-var_dump(ini_get_all("nosuchextension"));
+try {
+    ini_get_all("");
+} catch (ValueError $exception) {
+    echo $exception->getMessage() . "\n";
+}
+try {
+    var_dump(ini_get_all("nosuchextension"));
+} catch (ValueError $exception) {
+    echo $exception->getMessage() . "\n";
+}
 var_dump(ini_get_all("reflection"));
 var_dump(ini_get_all("pcre"));
 var_dump(ini_get_all("pcre", false));
 var_dump(ini_get_all("reflection", false));
-
-var_dump(ini_get_all("", ""));
+try {
+    ini_get_all("", "");
+} catch (ValueError $exception) {
+    echo $exception->getMessage() . "\n";
+}
 
 echo "Done\n";
 ?>
---EXPECTF--
+--EXPECT--
 string(5) "array"
-
-Warning: ini_get_all(): Unable to find extension '' in %s on line %d
-bool(false)
-
-Warning: ini_get_all(): Unable to find extension 'nosuchextension' in %s on line %d
-bool(false)
+Unable to find extension ''
+Unable to find extension 'nosuchextension'
 array(0) {
 }
 array(3) {
@@ -70,7 +77,5 @@ array(3) {
 }
 array(0) {
 }
-
-Warning: ini_get_all(): Unable to find extension '' in %sini_get_all.php on line %d
-bool(false)
+Unable to find extension ''
 Done