Promote warning to exception in log() function

Author: kocsismate

ext/opcache/Optimizer/zend_func_info.c

@@ -291,7 +291,7 @@ static const func_info_t func_infos[] = {
 	F0("log1p",                        MAY_BE_DOUBLE),
 	F1("pow",                          MAY_BE_NULL | MAY_BE_LONG | MAY_BE_DOUBLE | MAY_BE_OBJECT),
 	F0("exp",                          MAY_BE_DOUBLE),
-	F0("log",                          MAY_BE_FALSE | MAY_BE_DOUBLE),
+	F0("log",                          MAY_BE_DOUBLE),
 	F0("log10",                        MAY_BE_DOUBLE),
 	F0("sqrt",                         MAY_BE_DOUBLE),
 	F0("hypot",                        MAY_BE_DOUBLE),

ext/standard/basic_functions.stub.php

@@ -911,7 +911,7 @@ function pow($base, $exp) {}
 
 function exp(float $number): float {}
 
-function log(float $number, float $base = M_E): float|false {}
+function log(float $number, float $base = M_E): float {}
 
 function log10(float $number): float {}
 

ext/standard/basic_functions_arginfo.h

@@ -1386,7 +1386,7 @@ ZEND_END_ARG_INFO()
 
 #define arginfo_exp arginfo_ceil
 
-ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_log, 0, 1, MAY_BE_DOUBLE|MAY_BE_FALSE)
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_log, 0, 1, IS_DOUBLE, 0)
 	ZEND_ARG_TYPE_INFO(0, number, IS_DOUBLE, 0)
 	ZEND_ARG_TYPE_INFO(0, base, IS_DOUBLE, 0)
 ZEND_END_ARG_INFO()

ext/standard/math.c

@@ -679,7 +679,7 @@ PHP_FUNCTION(log1p)
 }
 /* }}} */
 
-/* {{{ proto float|false log(float number, [float base])
+/* {{{ proto float log(float number, [float base])
    Returns the natural logarithm of the number, or the base log if base is specified */
 PHP_FUNCTION(log)
 {
@@ -710,8 +710,8 @@ PHP_FUNCTION(log)
 	}
 
 	if (base <= 0.0) {
-		php_error_docref(NULL, E_WARNING, "base must be greater than 0");
-		RETURN_FALSE;
+		zend_value_error("Base must be greater than 0");
+		return;
 	}
 
 	RETURN_DOUBLE(log(num) / log(base));

ext/standard/tests/math/log_error.phpt

@@ -4,7 +4,11 @@ Test log() - wrong params test log()
 precision=14
 --FILE--
 <?php
-log(36, -4);
+try {
+    log(36, -4);
+} catch (ValueError $exception) {
+    echo $exception->getMessage() . "\n";
+}
 ?>
---EXPECTF--
-Warning: log(): base must be greater than 0 in %s on line %d
+--EXPECT--
+Base must be greater than 0