Remove superfluous sapi/ include step

Author: SammyK

ext/zend_test/tests/observer_generator_06.phpt

@@ -0,0 +1,43 @@
+--TEST--
+Observer: Generator yield from
+--SKIPIF--
+skip: TODO Fix this test
+<?php if (!extension_loaded('zend_test')) die('skip: zend_test extension required'); ?>
+--INI--
+zend_test.observer.enabled=1
+zend_test.observer.observe_all=1
+zend_test.observer.show_return_value=1
+--FILE--
+<?php
+function fooResults() {
+    yield from [0, 1, 2];
+}
+
+function doSomething() {
+    $generator = fooResults();
+    foreach ($generator as $value) {
+        echo $value . PHP_EOL;
+    }
+    return 'Done.';
+}
+
+echo doSomething() . PHP_EOL;
+?>
+--EXPECTF--
+<!-- init '%s/observer_generator_%d.php' -->
+<file '%s/observer_generator_%d.php'>
+  <!-- init doSomething() -->
+  <doSomething>
+    <!-- init fooResults() -->
+    <fooResults>
+    </fooResults:0>
+0
+    <fooResults>
+    </fooResults:1>
+1
+    <fooResults>
+    </fooResults:2>
+2
+  </doSomething:'Done.'>
+Done.
+</file '%s/observer_generator_%d.php'>

ext/zend_test/tests/observer_generator_07.phpt

@@ -0,0 +1,24 @@
+--TEST--
+Observer: Generator with uncaught TypeError
+--SKIPIF--
+<?php if (!extension_loaded('zend_test')) die('skip: zend_test extension required'); ?>
+--INI--
+zend_test.observer.enabled=1
+zend_test.observer.observe_all=1
+zend_test.observer.show_return_value=1
+--FILE--
+<?php
+function gen(array $a) { yield; }
+gen(42);
+?>
+--EXPECTF--
+<!-- init '%s/observer_generator_%d.php' -->
+<file '%s/observer_generator_%d.php'>
+  <!-- Exception: TypeError -->
+</file '%s/observer_generator_%d.php'>
+
+Fatal error: Uncaught TypeError: gen(): Argument #1 ($a) must be of type array, int given, called in %s:%d
+Stack trace:
+#0 %s/observer_generator_%d.php(%d): gen(42)
+#1 {main}
+  thrown in %s/observer_generator_%d.php on line %d

sapi/embed/README.md

@@ -31,14 +31,13 @@ int main(int argc, char **argv)
 }
 ```
 
-To compile this, we must point the compiler to the PHP header files. The paths to the header files are listed from `php-config --includes`, but the path to the SAPI header files are not included in that list by default so we must explicitly include `$(php-config --include-dir)/sapi`.
+To compile this, we must point the compiler to the PHP header files. The paths to the header files are listed from `php-config --includes`.
 
 We must also point the linker and the runtime loader to the `libphp.so` shared lib for linking PHP (`-lphp`) which is located at `$(php-config --prefix)/lib`. So the complete command to compile ends up being:
 
 ```bash
 $  gcc \
 	$(php-config --includes) \
-	-I$(php-config --include-dir)/sapi \
 	-L$(php-config --prefix)/lib \
 	embed_sapi_basic_example.c \
 	-lphp \