Skip to content

Commit 76225c1

Browse files
SammyKnikic
andauthored
Apply suggestions from code review
Co-authored-by: Nikita Popov <nikita.ppv@googlemail.com>
1 parent 7759b59 commit 76225c1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

sapi/embed/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# The embed SAPI
22

3-
A server application programming interface (SAPI), is the entry point into the Zend Engine. The embed SAPI is a lightweight SAPI for calling into the Zend Engine from C or other languages that have C bindings.
3+
A server application programming interface (SAPI) is the entry point into the Zend Engine. The embed SAPI is a lightweight SAPI for calling into the Zend Engine from C or other languages that have C bindings.
44

55
## Basic Example
66

@@ -31,7 +31,7 @@ int main(int argc, char **argv)
3131
}
3232
```
3333
34-
To compile this, we must point the compiler to the PHP header files. The paths to the header files are listed from (`php-config --includes`) but the path to the SAPI header files are not included in that list by default so we must explicitly include `$(php-config --include-dir)/sapi`.
34+
To compile this, we must point the compiler to the PHP header files. The paths to the header files are listed from `php-config --includes`, but the path to the SAPI header files are not included in that list by default so we must explicitly include `$(php-config --include-dir)/sapi`.
3535
3636
We must also point the linker and the runtime loader to the `libphp.so` shared lib for linking PHP (`-lphp`) which is located at `$(php-config --prefix)/lib`. So the complete command to compile ends up being:
3737
@@ -81,7 +81,7 @@ int main(int argc, char **argv)
8181
php_var_dump(&retval, 1);
8282
}
8383

84-
zend_string_free(func_name);
84+
zend_string_release(func_name);
8585

8686
PHP_EMBED_END_BLOCK()
8787
}

0 commit comments

Comments
 (0)